Nofap is not the problem. Not ejaculating might be the problem. If a man practices nofap and no porn, he needs to be getting laid regularly. Sex droughts can happen to anyone, but finding a way to get laid regularly is crucial. A man must either manage LTRs well over time (serial monogamy or traditional marital monogamy) or manage casual sex, "plating" type arrangements well. A lot of nofap guys aren't getting laid enough.
Below is an article about lack of sex in Gen Z (1997-2012 births). The older part of Gen Z (1997-2006 births) has reached sexual maturity now. This is part of a long term trend as many Millennials (1981-1996 births) were having less sex in the 2000s-2010s as well.
Reading Time – 8 minutes Most people have no idea how infrequent young people are having sex these days as compared to prior generations. My generation, Gen X, was having more sex than the Millennials when we were young, and I’ve commented on that fact...
alphamale20.com
While nofap/no porn is a recommended attraction/seduction practice, it doesn't create superpowers with getting laid regularly. In addition to no fap/no porn, these are some other attraction/seduction practices men will need in their lives. These elements are as important as nofap/no porn and some might even be more important.
-Looks: While there are elements of looks that can't be controlled, many can be. Diet and exercise are #1, especially for men under 45-50. Having a physique with some muscle definition and low body fat helps a lot. That's the #1 elements of looks. This is achieved through some combination of weight lifting and participation in a sport. Some blue collar manual laborers won't have as much of a need to lift weights in a gym because their work duties serve as enough of a replacement for the gym. White collar office workers need to lift weights. Participation in a sport depends on one's individual preferences.
-Height: White women in the USA tend to expect White men in the USA to be 6'0"+. USA Millennial and Gen Z White women have been conditioned to think men below 6'0" are absolute trash. It's very difficult to change height and even more average 5'9"-5'10" type men have a more difficult battle if they're White.
@Mike32ct has been well known for promoting height and hair as important elements of looks. Balding will hurt a man's prospects too, especially 30s/40s age balding. There are many elements of looks and I'm not going to mention all in this post.
Money: Money matters. While looks are more important than money for attraction in conventional dating under ages 30-35, it's still important. Women also tend to consider money more with mature men (35+). Most white collar guys will get judged on their money/career achievements. Watch what happens when a white collar man becomes unemployed. A typical white collar man's SMV is more tied to his job than the SMV of a blue collar or McJob worker man. A blue collar worker or McJob worker might be able to withstand a period of unemployment better in terms of keeping women attracted to him than a white collar worker.
There are also status and personality factors too.
Nofap/no porn is a good seduction practice but it needs to be combined with a lot of other things to actually be meaningful.